Skip to content

[No QA] Helpsite workflows naming#89706

Merged
stephanieelliott merged 9 commits intomainfrom
helpsite-workflows-naming
May 6, 2026
Merged

[No QA] Helpsite workflows naming#89706
stephanieelliott merged 9 commits intomainfrom
helpsite-workflows-naming

Conversation

@stephanieelliott
Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott commented May 6, 2026

@stephanieelliott stephanieelliott self-assigned this May 6, 2026
@stephanieelliott stephanieelliott requested a review from a team May 6, 2026 04:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @strepanier03

@melvin-bot melvin-bot Bot requested review from strepanier03 and removed request for a team May 6, 2026 04:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14a8094e21

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Learn how to [enable Approvals](https://help.expensify.com/articles/new-expensify/workspaces/Add-Approvals) on your workspace.

## How to Set a Submission Frequency
## How to enable Submissions
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the self-link anchor after renaming the heading

Changing this heading changes the generated help-site fragment from #how-to-set-a-submission-frequency to #how-to-enable-submissions, but this same section still links readers to the old fragment on line 59 (Workspace-Workflows#how-to-set-a-submission-frequency). On the published article, the “configure Submissions” link will no longer jump to this section after the heading rename, so either preserve the old anchor or update the link target.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

HelpDot Documentation Review

Overall Assessment

This PR updates UI terminology across 9 documentation files to match the current product labels. Specifically, it renames "Add Approvals" to "Approvals," "Make or track payments" to "Payments," and "Set a Submission Frequency" to "enable Submissions." These are targeted, consistent find-and-replace changes that align the documentation with the actual UI, which is exactly what the governance rules require.

Scores Summary

  • Readability: 9/10 - The changes are clean substitutions that maintain existing sentence flow and step clarity. No readability regressions introduced.
  • AI Readiness: 9/10 - Using the exact current UI feature names improves retrieval accuracy. Heading changes (e.g., "How to enable Approvals," "How to enable Submissions") remain task-based with action verbs and feature names, satisfying HELP_AUTHORING_GUIDELINES.md Section 2 and Section 6.
  • Style Compliance: 9/10 - The renamed labels follow HELPSITE_NAMING_CONVENTIONS.md rules: exact UI text, correct casing, bold formatting on interactive elements. One minor inconsistency noted below.

Key Findings

  • Positive: The PR is well-scoped and systematically updates all occurrences of the old terminology across the documentation. This is exactly the kind of maintenance the governance files call for ("If the UI changes, this document must be updated").
  • Positive: Cross-link anchor text was also updated (e.g., "learn how to enable Approvals" instead of "learn how to add approvals"), which aligns with the HELP_AUTHORING_GUIDELINES.md anchor text rules requiring descriptive, task-based link text.
  • Minor inconsistency: In Workspace-Workflows.md, the heading "How to enable Approvals" uses lowercase "enable" while "Approvals" is capitalized. This is acceptable since it follows sentence case for the verb while preserving the exact UI label. However, the same pattern applies to the new heading "How to enable Submissions" -- confirm that "Submissions" is the exact label shown in the UI.
  • Pre-existing issue (not introduced by this PR): Several of the touched files still contain non-relative links (e.g., full https://help.expensify.com/... URLs in Track-Personal-Expenses.md and Workspace-Workflows.md), which conflicts with the cross-linking standards in HELP_AUTHORING_GUIDELINES.md Section 7. This is not a problem introduced by this PR, so no score penalty is applied, but it may be worth addressing in a follow-up.

Recommendations

  1. Verify that "Approvals," "Payments," and "Submissions" are the exact labels currently displayed in the product UI. The governance rules require exact match with no paraphrasing.
  2. Consider a follow-up PR to convert the remaining full URLs to relative links in the files touched here, per the cross-linking standards.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Create-a-company-workspace.md - "Add Approvals" renamed to "Approvals." Clean.
  • docs/articles/new-expensify/getting-started/Track-Personal-Expenses.md - "Make or track payments" renamed to "Payments." Clean.
  • docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md - Anchor text updated to "learn how to enable Approvals." Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Australia.md - Two references updated to "Payments." Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Europe.md - One reference updated to "Payments." Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-Kingdom.md - Two references updated to "Payments." Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-States.md - Two references updated to "Payments." Clean.
  • docs/articles/new-expensify/workspaces/Add-Approvals.md - Three references updated from "Add approvals" to "Approvals." Clean.
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md - Headings and link text updated for Approvals and Submissions. Clean.

This review assessed only the proposed changes in the diff, not unchanged content.

@github-actions github-actions Bot changed the title Helpsite workflows naming [No QA] Helpsite workflows naming May 6, 2026
@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 6, 2026
Copy link
Copy Markdown
Contributor

@strepanier03 strepanier03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed each change and confirmed changes are accurate in the build. LGTM

@strepanier03
Copy link
Copy Markdown
Contributor

I can merge this but see there is a request to review for @jamesdeanexpensify - I'll check again later.

@stephanieelliott
Copy link
Copy Markdown
Contributor Author

Just added James for viz but we already discussed the updates. I think we are good to merge!

@stephanieelliott stephanieelliott merged commit 2955a81 into main May 6, 2026
24 of 26 checks passed
@stephanieelliott stephanieelliott deleted the helpsite-workflows-naming branch May 6, 2026 22:16
@melvin-bot melvin-bot Bot added the Emergency label May 6, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 6, 2026

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants